Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15045: Execute local leader commit in parallel with distributed commits in DistributedZkUpdateProcessor #2449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

magibney
Copy link
Contributor

@magibney magibney commented Mar 3, 2021

See also: SOLR-15045

NOTE: this test jumps through hoops to support "failure" expressed as
success, for compatibility with the way distrib shard commit errors
are (not) currently propagated back to the client. This behavior is
likely a bug in its own right that should be addressed separately,
probably before this fix is committed
@magibney
Copy link
Contributor Author

magibney commented Mar 4, 2021

fwiw, I think the gradle precommit is failing on a nocommit comment marking a question about why TOLEADER distrib commit errors aren't propagated back to the client ... not really an issue with this PR per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant